There are duplicates here. Try to get the develop CHANGELOG and only add your PR to the top.

There can be made some discussion here on the severity of it, but this is likely a breaking change: the default of this attribute should be False, otherwise all the current code with hybrid motors would have its behavior changed. Do you agree @Gui-FernandesBR ?

This parameter needs to be documented in the class and __init__ docstrings.

I don't oppose to it if needed, but any particular reason for changing the fixture name?

Similarly to the other tests, docstrings are needed to describe it and its fixture parameters.

This is quite dangerous. I did not test nor exhaustively review the code, but here are some of my comments that I believe are relevant (feel free to correct me on that) if you want to support setting (post instantiation) this attribute:

• The SolidMotor.evaluate_geometry method also sets some of the instance attributes, such as self.grain_burn_out and self.grain_inner_radius;
• Simply toggling the attribute only_radial_burn would not change the values of those attributes, therefore their old values would be kept.

On the top of my head, I see two possible solutions here:

1. Supporting this toggling after instantiation in which other values of the class should be adapted is the task of a setter:

class SolidMotor(Motor):
    def __init__(self, ..., only_radial_burn=False):
        ...
        self._only_radial_burn = only_radial_burn

    @property
    def only_radial_burn(self):
        return self._only_radial_burn

    @only_radial_burn.setter
    def only_radial_burn(self, value):
        self._only_radial_burn = value
        self.evaluate_geometry()

class HybridMotor(Motor):
    def __init__(self, ..., only_radial_burn=False):
        ...
        self._only_radial_burn = only_radial_burn

    @property
    def only_radial_burn(self):
        return self._only_radial_burn

    @only_radial_burn.setter
    def only_radial_burn(self, value):
        self.solid.only_radial_burn = value
        reset_funcified_method(self)

2. Alternative simpler solution: another possibility is to disallow the toggling of this attribute after instantiation. This is possible by using a property with no setter. In this way, the radial burn can only be selected on instantiation.

class SolidMotor(Motor):
    def __init__(self, ..., only_radial_burn=False):
        ...
        self._only_radial_burn = only_radial_burn

    @property
    def only_radial_burn(self):
        return self._only_radial_burn

@caioessouza could you confirm this is the case, i.e., toggling this attribute would cause the defined attributes from evaluate_geometry incorrectly keep their old values? If I understood things correctly, the tests for this new parameter did not catch that, which means they have room for improvement.

I, personally, have a slight preference for option 2, since it avoids complicating more this already delicate interaction between the motor types. Do you have any suggestions @MateusStano or @Gui-FernandesBR ?

I think the best option is to make only_radial_burn not mutable.

This would make life much easier.

If you want to modify the value of only_radial_burn after instanciating the object, you should instantiate another object